Repository navigation
Improved: Remove the unused shutdown trap and stop-signal script from the Docker image (OFBIZ-13809) - #2580
Merged
Conversation
…r image The entrypoint trapped SIGTERM and SIGINT to run send_ofbiz_stop_signal.sh, but it ends with exec, so the OFBiz JVM replaces the shell and receives the stop signal itself, and docker stop already shuts OFBiz down gracefully through its shutdown hook. The trap never ran, so remove it together with the script and the curl package that was only installed for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker entrypoint trapped SIGTERM and SIGINT to run send_ofbiz_stop_signal.sh, which sends SHUTDOWN to the admin port, but the entrypoint ends with exec, so the OFBiz JVM replaces the shell and receives the stop signal directly; docker stop already shuts OFBiz down gracefully through its shutdown hook, so the trap never ran. This removes the trap, the script and the curl package that was installed only for it. A demo image built from this change still loads its data on first run, and docker stop still stops OFBiz cleanly.