Repository navigation
Fixed: One JobSandbox row with sub-millisecond runTime stalls the whole job poller (OFBIZ-13808) - #2578
Merged
Conversation
PersistedServiceJob formatted JobSandbox.runTime to a string and parsed it back with a formatter that accepts at most three fractional digits, even when runTimeEpoch was set. A runTime with microsecond or nanosecond precision threw a DateTimeParseException inside JobManager.poll(), which rolled back the whole poll, so a single such row stopped every scheduled job. The formatter also read the fraction as microseconds, dropping the milliseconds of a normal value. Use runTimeEpoch when it is set and otherwise take the epoch directly from the runTime timestamp, and remove the now unused formatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PersistedServiceJob parsed JobSandbox.runTime as a string with a formatter limited to three fractional digits, so a runTime with microsecond precision (for example set by SQL on PostgreSQL) threw a DateTimeParseException from JobManager.poll(), which rolled back the poll and stopped every scheduled job while that row remained; the formatter also dropped the milliseconds of normal values. The start time now comes from runTimeEpoch when set, or directly from the runTime timestamp, and the formatter is removed.