apps/nxinit: Make init.rc file path configurable#3506
Merged
Conversation
Fix typo in help string. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
linguini1
force-pushed
the
nxinit-path-conf
branch
from
b3c0c86 to
411478d
Compare
Would not compile due to typo in macro describing service name length. Change ensures that: * We do not malloc an extra `len` bytes since this is already allocated as part of the struct * The name string always has a null terminating byte Signed-off-by: Matteo Golin <matteo.golin@gmail.com> FIx
The init.rc file path is now configurable to allow users to choose where to put the startup script. This is useful for devices that mount external media to a special directory like `/sd`. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
Without debug enabled, the code would not compile due to checking `WIFEXITED(wstatus)` when `wstatus` was uninitialized. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
linguini1
force-pushed
the
nxinit-path-conf
branch
from
411478d to
cf5b825
Compare
cederom
approved these changes
May 28, 2026
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @linguini1 :-)
lupyuen
approved these changes
May 28, 2026
acassis
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The init.rc file path is now configurable to allow users to choose where to put the startup script. This is useful for devices that mount external media to a special directory like
/sd.Also fixed some compilation errors not caught earlier.
Documentation update here: apache/nuttx#18981
Impact
Better user experience with NXInit.
Testing
N/A.