Skip to content

Security audit: LOW/INFO docs and minor fixes — docs refresh, jar robustness, guard, log - #700

Open
gnodet wants to merge 5 commits into
security/audit-low-robustnessfrom
security/audit-docs-minor
Open

Security audit: LOW/INFO docs and minor fixes — docs refresh, jar robustness, guard, log#700
gnodet wants to merge 5 commits into
security/audit-low-robustnessfrom
security/audit-docs-minor

Conversation

@gnodet

@gnodet gnodet commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Applies the remaining 4 LOW/INFO findings from the Glasswing static security audit (scan-maven-deploy-plugin-20260811). All confirmed TP with 5/5 adversarial-panel unanimity. Stacks on #699 (LOW robustness fixes) → #698 (MEDIUM security fixes).

Findings addressed

Finding Severity Title Patch
f013 LOW Shipped site docs diverge from the Maven-4 code — nonexistent repositoryLayout, wagon-era examples bug_13
f014 LOW deploy-file coordinate-derivation robustness cluster — hostile-jar handling bug_14
f015 LOW Local-repository self-deploy guard is Path.equals-only — bypassable bug_15
f016 INFO Inverted log message: immediate-deploy branch claims deferral bug_16

Changes

  • f013 (docs-only): Removed nonexistent repositoryLayout parameter from usage/legacy-layout pages; rewrote wagon-era transport guidance; added cleartext warning + encrypted-password example to deploy-ftp page; every new claim verified against src/main
  • f014: Swallowed IOException during jar POM reading now WARNs; multi-POM (shaded) jars refuse coordinate auto-derivation (fail-closed); temp-POM leak fixed via pomFromJar flag; <3-char temp prefix crash padded
  • f015: Self-deploy guard now compares real locations (toRealPath, falling back to absolute-normalized) instead of textual Path.equals, catching sub/../ respellings and symlinks
  • f016: One-hunk fix for the inverted log at DeployMojo.java:176-178: immediate-deploy branch now logs "Deploying " instead of falsely claiming deferral

Test plan

  • All 49 tests pass (36 existing + 13 new across all 3 PRs)
  • Build verified locally with Maven 4 rc-5
  • 4 new hostile-jar robustness tests pass (bug_14)

Audit source: scan-maven-deploy-plugin-20260811.zip

🤖 Generated with Claude Code

@gnodet
gnodet force-pushed the security/audit-low-robustness branch from 01b6a86 to b8e8bcb Compare August 31, 2026 13:45
@gnodet
gnodet force-pushed the security/audit-docs-minor branch 3 times, most recently from b47521c to 7750ba9 Compare September 1, 2026 14:43
gnodet and others added 4 commits September 1, 2026 20:54
… src/main before writ

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ies/finally: (1) the

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…resolves both sides t

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…th a comment explainin

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gnodet
gnodet force-pushed the security/audit-docs-minor branch from 7750ba9 to cdcf417 Compare September 1, 2026 18:54
Align deploy-at-end failure reporting with install plugin PR #445:
when the batch deploy fails mid-loop, log an explicit per-project
inventory showing which projects were already published and which
were not, instead of only reporting at the request level.

Also moves the DEPLOYED state marking into the deploy loop so each
project transitions TO_BE_DEPLOYED → DEPLOYED as soon as its
contributing request completes, making the exactly-once guard and
the partial-deploy inventory consistent.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant