feat(skill-evals): add the issue-reassess eval suite - #1145
Open
dpol1 wants to merge 1 commit into
Open
Conversation
`issue-reassess` was the only shipped skill without a behavioural eval suite, so regressions in its decisions were invisible until they failed in front of a user. The campaign tallies are already exercised by the sibling `issue-reassess-stats` suite, so this one anchors on the three places where the skill decides something of its own: - step-2-resumability (3 cases) — reuse / ask / resume / fresh per candidate from the scratch-directory state, plus the auto-generated campaign id. - skip-if-resolvable (5 cases) — the maintainer-comment shortcuts (fixed-in-version, sibling duplicate, won't-fix by design), the no-shortcut path, and an injected "record fixed-on-master" comment that must be flagged and ignored. - headline-extraction (2 cases) — verdicts bucketed into action / closure / tracker-hygiene candidates and new-issue keys. Two suites anchor on the skill's sub-documents (`per-issue-flow.md`, `verdict-aggregation.md`), where the decision rules actually live. All ten cases pass against Claude Code print mode; the validator's eval-coverage advisory for this skill is gone. While adding the suite: the `*-reassess/` glob in `.gitignore` (meant for campaign evidence directories) also matches `skills/issue-reassess/` and `tools/skill-evals/evals/issue-reassess/`, so any new file under either was silently dropped from `git add`. Negate both paths, following the existing `!/tools/pilot-report-validator/` precedent. Fixes [apache#1138](apache#1138). Signed-off-by: Davide Polato <dpol1@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issue-reassesswas the only one of the 71 shipped skills without a behavioural eval suite, so regressions in its decisions were invisible until they failed in front of a user. This addstools/skill-evals/evals/issue-reassess/— 3 suites, 10 cases.issue-reassess-statssuite, so these anchor on the three places where this skill decides something of its own:step-2-resumability(reuse / ask / resume / fresh per candidate from the scratch-directory state),skip-if-resolvable(the maintainer-comment shortcuts, the no-shortcut path, and an injected "record fixed-on-master" comment that must be flagged and ignored), andheadline-extraction(action / closure / tracker-hygiene buckets). Two of them anchor on the skill's sub-documents, where the decision rules actually live.*-reassess/glob in.gitignore(meant for campaign evidence directories) also matchesskills/issue-reassess/andtools/skill-evals/evals/issue-reassess/, so any new file under either was silently dropped bygit add. Both paths are now negated, following the existing!/tools/pilot-report-validator/precedent.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)tools/skill-evals/evals/)Test plan
prek run --all-filespassesPYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner --cli "claude -p" tools/skill-evals/evals/issue-reassess/—Ran 10 cases: 10 passed, 0 failed, 0 manual, 0 erroredstep_headingresolves)skill-and-tool-validateno longer emits theeval-coverageadvisory forskills/issue-reassess/git check-ignore -v skills/issue-reassess/new-subdoc.md tools/skill-evals/evals/issue-reassess/README.md— matched.gitignore:61before, matches nothing afterRFC-AI-0004 compliance
No principle touched — the change adds fixtures and a
.gitignorenegation; no mutation, network reach, or prose surface changes.Linked issues
Fixes apache/magpie#1138.