fix(skills): derive the two remaining Airflow literals from project config - #1144
Open
dpol1 wants to merge 1 commit into
Open
fix(skills): derive the two remaining Airflow literals from project config#1144dpol1 wants to merge 1 commit into
dpol1 wants to merge 1 commit into
Conversation
…onfig `pr-management-stats/fetch.md` queried `repository(owner:"apache",name:"airflow")` in its GraphQL batch-fetch recipe, and `release-announce-draft` pinned the download URL to `closer.lua?path=airflow/<version>/`. Both are operative instructions, not examples, so an agent following them against another adopter queries the wrong repository and points at the wrong dist tree. Bind the query's owner/name from `<upstream>` the way the other GraphQL recipes already do, and render the dist path from `<project>` as the rest of the announce skill does. Teach `check-placeholders.sh` the two lowercase forms (`name:"airflow"`, `path=airflow`) so this class is caught at commit time — before this change the linter passed on both lines. Fixes [apache#1139](apache#1139). Signed-off-by: Davide Polato <dpol1@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-management-stats/fetch.mdqueriedrepository(owner:"apache",name:"airflow")in its GraphQL batch-fetch recipe, andrelease-announce-draftpinned the download URL tocloser.lua?path=airflow/<version>/. Both are operative instructions, not examples — an agent following them against any other adopter queries the wrong repository and points the announce at the wrong dist tree.$owner/$repofrom<upstream>the way the other GraphQL recipes (contributor-*,pr-management-code-review) already do, and the dist path renders from<project>, which the same announce skill already uses fordist/release/<project>/<version>/. No new placeholder.check-placeholders.shlearns the two lowercase forms (name:"airflow",path=airflow). Before this change it passed on both lines — which is how they survived the template clean-up in fix(_template): drop Apache Airflow residue from the templates #1132.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassestools/dev/check-placeholders.shfails on exactlyfetch.md:213andrelease-announce-draft/SKILL.md:363and nothing else; after the two edits it passes again.grep -rn 'airflow' skills/sweep: the remaining hits are marked examples (candidate-rules.md, theissue-triageJIRA-key example, slop-detection fixtures) and stay as they are.RFC-AI-0004 compliance
<PROJECT>,<tracker>,<upstream>,<security-list>) used in all skill / tool prose (thecheck-placeholdersprek hook is the mechanical gate)Linked issues
Fixes apache/magpie#1139.