fix(stream): allow group and consumer names starting with digits#3442
Open
songqing wants to merge 3 commits intoapache:unstablefrom
Open
fix(stream): allow group and consumer names starting with digits#3442songqing wants to merge 3 commits intoapache:unstablefrom
songqing wants to merge 3 commits intoapache:unstablefrom
Conversation
Redis does not restrict group or consumer names from starting with digits. The restriction was kvrocks-specific and broke compatibility.
Member
|
Hi @Yangsx-1. I noticed that you authored the original code. Was there a specific rationale behind this implementation? |
|
jihuayu
approved these changes
Apr 13, 2026
Member
jihuayu
left a comment
jihuayu
left a comment
There was a problem hiding this comment.
LGTM. There's no point in limiting this to non-numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis does not restrict group or consumer names from starting with digits. The restriction was kvrocks-specific and broke compatibility.