KAFKA-20864: Fix to avoid early batch close if extension fails - #23008
Open
lianetm wants to merge 2 commits into
Open
KAFKA-20864: Fix to avoid early batch close if extension fails#23008lianetm wants to merge 2 commits into
lianetm wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following fixes to avoid closing the wrong batch
when a mid-batch extension acquire fails on an exhausted pool:
it's not, do not close it and continue the loop, so the next iteration
checks against whatever is open (will take the new-batch path if
nothing is open, or retry with the new open batch, sizing the extension
needed again)
by always allowing a first attempt (it's non-blocking), but bound
retries against the remaining max.block.ms. Edge case to ensure send
does not exceed max.block.ms if the extension keeps failing with the
batch being replaced.
count against max.block.ms (like the blocking ops do)