KAFKA-20870: Add test for the owned-task report for a single-role assignment change - #23002
Open
mjsax wants to merge 1 commit into
Open
KAFKA-20870: Add test for the owned-task report for a single-role assignment change#23002mjsax wants to merge 1 commit into
mjsax wants to merge 1 commit into
Conversation
…ignment change The broker reads the three owned-task lists in a StreamsGroupHeartbeat as a report of what the member holds only when all three are non-null; with any of them null it cannot tell that a task was released, so the member fails tonever acknowledges the revocation and the group stays in rebalancing. A change confined to one role therefore has to resend the other two lists as well, even though they did not change. While the client implements this already correctly, there is no explicit test for it. The problem is, that KIP-1071 does not specify this requirement atm. This PR adds an explicit test to avoid any accidental regression.
github-actions
Bot
added
consumer
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broker reads the three owned-task lists in a StreamsGroupHeartbeat
as a report of what the member holds only when all three are non-null;
with any of them null it cannot tell that a task was released, so the
member fails to acknowledge the revocation and the group stays in
rebalancing. A change confined to one role therefore has to resend the
other two lists as well, even though they did not change.
While the client implements this already correctly, there is no explicit
test for it. The problem is, that KIP-1071 does not specify this
requirement atm. This PR adds an explicit test to avoid any accidental
regression.