KAFKA-20858: Refactor subscription state - #22996
Open
AndrewJSchofield wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SubscriptionState class in the client is a core class in the
consumer and share consumer. It keeps track of all manner of consumer
state such as subscribed topics, assigned partitions and fetch
positions.
Although there are some concepts which are common to consumer group and
share group subscription state management, there are also many
differences.
This task refactors the subscription state to remove this false coupling
between group types, and give share groups better control over the
topics included in the metadata. It's a largely mechanical change.