KAFKA-20828: Return should client throttle true for throttle based responses - #22912
Closed
apoorvmittal10 wants to merge 1 commit into
Closed
KAFKA-20828: Return should client throttle true for throttle based responses#22912apoorvmittal10 wants to merge 1 commit into
apoorvmittal10 wants to merge 1 commit into
Conversation
Contributor
|
@apoorvmittal10 : Thanks for the PR. #22908 addresses the same issue and the approach seems more future proof. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractResponse.shouldClientThrottle() defaults to false, so responses
that carry a throttle_time_ms field but don't override it never trigger
client-side throttling — the client ignores the broker's throttle time
on quota violations.
This adds the missing override to every response that declares a
throttle_time_ms field, including the group heartbeat responses called
out in the JIRA (ConsumerGroupHeartbeatResponse,
ShareGroupHeartbeatResponse, StreamsGroupHeartbeatResponse).
OffsetsForLeaderEpochResponse returns version >= 2 (the version that
added the throttle field).
A regression test in RequestResponseTest asserts that every API whose
response schema has a throttle_time_ms field returns true from
shouldClientThrottle() at its latest version, so new APIs can't
reintroduce the bug.
Reviewers: Jun Rao junrao@gmail.com