Skip to content

Only send table deletion to related region groups#17896

Merged
jt2594838 merged 2 commits into
masterfrom
fix_deletion_broadcase
Jun 11, 2026
Merged

Only send table deletion to related region groups#17896
jt2594838 merged 2 commits into
masterfrom
fix_deletion_broadcase

Conversation

@jt2594838

Copy link
Copy Markdown
Contributor

Description

  • Query ConfigNode for DataRegion groups by delete database and deletion time range instead of reading the full region route map.
  • Add coverage for fetching delete replica sets from the target database/time ranges and avoiding getLatestRegionRouteMap.

Verification

  • mvn spotless:apply -pl iotdb-core/datanode
  • git diff --check
  • mvn test -pl iotdb-core/datanode -Dtest=AnalyzeUtilsTest (blocked during main compile by existing missing generated/dependency classes such as SubscriptionWalRetentionPolicy, RegionProgress, WriterId, WriterProgress, TGetCommitProgressReq, and RelationalSqlParser.NextFillContext)

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.83%. Comparing base (c3e74a2) to head (d0f885c).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...otdb/db/queryengine/plan/analyze/AnalyzeUtils.java 75.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17896      +/-   ##
============================================
+ Coverage     40.54%   40.83%   +0.28%     
+ Complexity     2622      318    -2304     
============================================
  Files          5244     5245       +1     
  Lines        362367   363213     +846     
  Branches      46651    46783     +132     
============================================
+ Hits         146938   148333    +1395     
+ Misses       215429   214880     -549     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi Caideyipi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I reviewed the change and did not find any blocking correctness issues. Routing table deletions through getRegionGroupsByTime by database and deletion time range matches the ConfigNode partition lookup semantics, and an empty region result is handled as a no-op by the write dispatch path. Optional follow-up: add coverage for non-success and empty/unset regionReplicaSets responses from ConfigNode.

@sonarqubecloud

Copy link
Copy Markdown

@jt2594838 jt2594838 merged commit 41393ab into master Jun 11, 2026
66 of 69 checks passed
@jt2594838 jt2594838 deleted the fix_deletion_broadcase branch June 11, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants