Skip to content

Fix the duplicate literals using the constant #17274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anukalp2804 wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −10
Open

Fix the duplicate literals using the constant #17274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions example/jdbc/src/main/java/org/apache/iotdb/TableModelJDBCExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
public class TableModelJDBCExample {

private static final Logger LOGGER = LoggerFactory.getLogger(TableModelJDBCExample.class);
private static final String SHOW_TABLES = "SHOW TABLES";

public static void main(String[] args) throws ClassNotFoundException, SQLException {
Class.forName("org.apache.iotdb.jdbc.IoTDBDriver");
Expand All @@ -57,7 +58,7 @@ public static void main(String[] args) throws ClassNotFoundException, SQLExcepti
"create table table2(region_id STRING TAG, plant_id STRING TAG, color STRING ATTRIBUTE, temperature FLOAT FIELD, speed DOUBLE FIELD) with (TTL=6600000)");

// show tables from current database
try (ResultSet resultSet = statement.executeQuery("SHOW TABLES")) {
try (ResultSet resultSet = statement.executeQuery(SHOW_TABLES)) {
ResultSetMetaData metaData = resultSet.getMetaData();
System.out.println(metaData.getColumnCount());
while (resultSet.next()) {
Expand Down Expand Up @@ -85,7 +86,7 @@ public static void main(String[] args) throws ClassNotFoundException, SQLExcepti
"jdbc:iotdb://127.0.0.1:6667/test1?sql_dialect=table", "root", "root");
Statement statement = connection.createStatement()) {
// show tables from current database test1
try (ResultSet resultSet = statement.executeQuery("SHOW TABLES")) {
try (ResultSet resultSet = statement.executeQuery(SHOW_TABLES)) {
ResultSetMetaData metaData = resultSet.getMetaData();
System.out.println(metaData.getColumnCount());
while (resultSet.next()) {
Expand All @@ -96,7 +97,7 @@ public static void main(String[] args) throws ClassNotFoundException, SQLExcepti
// change database to test2
statement.execute("use test2");

try (ResultSet resultSet = statement.executeQuery("SHOW TABLES")) {
try (ResultSet resultSet = statement.executeQuery(SHOW_TABLES)) {
ResultSetMetaData metaData = resultSet.getMetaData();
System.out.println(metaData.getColumnCount());
while (resultSet.next()) {
Expand Down
7 changes: 4 additions & 3 deletions example/session/src/main/java/org/apache/iotdb/TableModelSessionExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
public class TableModelSessionExample {

private static final String LOCAL_URL = "127.0.0.1:6667";
private static final String SHOW_TABLES = "SHOW TABLES";

public static void main(String[] args) {

Expand All @@ -63,7 +64,7 @@ public static void main(String[] args) {
"create table table2(region_id STRING TAG, plant_id STRING TAG, color STRING ATTRIBUTE, temperature FLOAT FIELD, speed DOUBLE FIELD) with (TTL=6600000)");

// show tables from current database
try (SessionDataSet dataSet = session.executeQueryStatement("SHOW TABLES")) {
try (SessionDataSet dataSet = session.executeQueryStatement(SHOW_TABLES)) {
System.out.println(dataSet.getColumnNames());
while (dataSet.hasNext()) {
System.out.println(dataSet.next());
Expand Down Expand Up @@ -140,7 +141,7 @@ public static void main(String[] args) {
.build()) {

// show tables from current database
try (SessionDataSet dataSet = session.executeQueryStatement("SHOW TABLES")) {
try (SessionDataSet dataSet = session.executeQueryStatement(SHOW_TABLES)) {
printDataSet(dataSet);
}

Expand All @@ -149,7 +150,7 @@ public static void main(String[] args) {

// show tables by specifying another database
// using SHOW tables FROM
try (SessionDataSet dataSet = session.executeQueryStatement("SHOW TABLES")) {
try (SessionDataSet dataSet = session.executeQueryStatement(SHOW_TABLES)) {
printDataSet(dataSet);
}

Expand Down
9 changes: 5 additions & 4 deletions example/session/src/main/java/org/apache/iotdb/TableModelSessionPoolExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
public class TableModelSessionPoolExample {

private static final String LOCAL_URL = "127.0.0.1:6667";
private static final String SHOW_TABLES = "SHOW TABLES";

public static void main(String[] args) {

Expand Down Expand Up @@ -78,7 +79,7 @@ public static void main(String[] args) {
+ "speed DOUBLE FIELD) with (TTL=6600000)");

// show tables from current database
try (SessionDataSet dataSet = session.executeQueryStatement("SHOW TABLES")) {
try (SessionDataSet dataSet = session.executeQueryStatement(SHOW_TABLES)) {
printDataSet(dataSet);
}

Expand Down Expand Up @@ -157,7 +158,7 @@ public static void main(String[] args) {
try (ITableSession session = tableSessionPool.getSession()) {

// show tables from current database
try (SessionDataSet dataSet = session.executeQueryStatement("SHOW TABLES")) {
try (SessionDataSet dataSet = session.executeQueryStatement(SHOW_TABLES)) {
printDataSet(dataSet);
}

Expand All @@ -166,7 +167,7 @@ public static void main(String[] args) {

// show tables by specifying another database
// using SHOW tables FROM
try (SessionDataSet dataSet = session.executeQueryStatement("SHOW TABLES")) {
try (SessionDataSet dataSet = session.executeQueryStatement(SHOW_TABLES)) {
printDataSet(dataSet);
}

Expand All @@ -179,7 +180,7 @@ public static void main(String[] args) {
try (ITableSession session = tableSessionPool.getSession()) {

// show tables from default database test1
try (SessionDataSet dataSet = session.executeQueryStatement("SHOW TABLES")) {
try (SessionDataSet dataSet = session.executeQueryStatement(SHOW_TABLES)) {
printDataSet(dataSet);
}

Expand Down