Repository navigation
fix: install active modules from source archives - #381
Merged
Merged
Conversation
- remove legacy ML from root extras and local sources - keep the standalone ML module and archive exclusion - verify client and LLM installs in the archive CI step - document the separate legacy ML workflow
imbajin
marked this pull request as ready for review
October 10, 2026 07:35
- keep the ML workspace reminder concise - remove maintenance and legacy wording - retain the standalone installation command
- install all workspace packages with native uv sync - check dependency consistency with uv pip check - remove inline Python import lists
MrJs133
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache source archives exclude the ML directory, but the root project still declares it as a local dependency. As a result, even
uv sync --extra llmor--extra python-clientfails while resolving extras.Remove ML from the root extras and local sources so the active modules install directly from source archives. Keep the ML module at 1.7.0 and preserve its archive exclusion; document its standalone installation command.
Extend the existing archive CI step to install all workspace packages with
uv sync --all-packagesand verify dependency consistency withuv pip checkon Python 3.10/3.11. Runtime behavior stays covered by the existing client and LLM test suites. Local verification started from an archive without ML or a lockfile: both installs and imports passed, as did package builds, Ruff, and independent diff review.The simplified native uv verification passed locally from a fresh archive without ML, a lockfile, or a virtual environment. Current-head CI passed, including the native archive verification on Python 3.10/3.11: client, LLM, Ruff, license, CodeQL, and MCP.