-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-30059: LLAP IO Cache: native parquet data cache #6793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abstractdog
wants to merge
16
commits into
apache:master
Choose a base branch
from
abstractdog:parquet-io-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a3d1398
HIVE-30059: Layout and read buffers for Parquet column chunks in the …
deniskuzZ 2997879
HIVE-30059: Extract Parquet row-group column-reader construction into…
deniskuzZ 30707a4
HIVE-30059: Cache and decode Parquet column chunks in LLAP IO
deniskuzZ f82cffe
HIVE-30059: Count Parquet footer cache hits and misses in the LLAP IO…
abstractdog a640a58
unused import
abstractdog b6965fe
clarifying comment on LlapCacheAwareFs
abstractdog 8520619
cacheMetrics.incrCacheReadRequests for parity with OrcColumnVectorPro…
abstractdog 144338b
createReadPipeline doesn't throw exception
abstractdog 5fe68d2
final metrics fields in OrcColumnVectorProducer
abstractdog 39faf0d
QueryFragmentCounters parity with ORC
abstractdog b3d0f24
Simple test for QueryFragmentCounters parity with ORC
abstractdog b7bc579
Address Denys's PR review comments
abstractdog acef649
HIVE_VECTORIZED_INPUT_FORMAT_SUPPORTS_DECIMAL_64
abstractdog 289c66f
Address Copilot review comments on PR #6793
abstractdog e4f42ce
Address SonarCloud findings on PR #6793
abstractdog 65352ad
ubuntu hack
abstractdog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapParquetReadRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hive.llap.io.api; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hadoop.hive.common.io.CacheTag; | ||
|
|
||
| /** | ||
| * Everything that identifies a single Parquet split served through the LLAP data cache: the file | ||
| * (its optional {@code fileKey}, {@code path} and {@code tag}), the split ({@code offset} and | ||
| * {@code length}), the projection ({@code tableIncludedCols}), and the defaults for columns | ||
| * absent from the file ({@code initialDefaults}). Kept together so | ||
| * {@link LlapIo#llapVectorizedParquetReaderForPath} stays a three-parameter call with the job | ||
| * conf and reporter alongside. | ||
| */ | ||
| public record LlapParquetReadRequest( | ||
| Object fileKey, | ||
| Path path, | ||
| CacheTag tag, | ||
| List<Integer> tableIncludedCols, | ||
| long offset, | ||
| long length, | ||
| Map<String, Object> initialDefaults) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't be this enabled by default?