HIVE-29582: Exclude test jars from lib directory (Naveen Gangam)#6455
Open
nrg4878 wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29582: Exclude test jars from lib directory (Naveen Gangam)#6455nrg4878 wants to merge 1 commit intoapache:masterfrom
nrg4878 wants to merge 1 commit intoapache:masterfrom
Conversation
|
dengzhhu653
approved these changes
Apr 28, 2026
ayushtkn
approved these changes
Apr 28, 2026
Member
ayushtkn
left a comment
There was a problem hiding this comment.
I couldnt quite figure out where in the dependency tree this was getting pulled in from but generally is a good idea to exclude all tests.jar files from the lib.
This llap-common-tests that you see in the lib is most probably because of missing <scope>tests<scope> here
Lines 330 to 335 in ee6848d
By default it is taking compile scope and getting packaged. Would be good to correct there as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
POM changes to exclude test jars from the lib directory.
Why are the changes needed?
Cleaner practices and smaller distributions
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually