HIVE-29551: Avoid quadratic runtime in ColumnStatsSemanticAnalyzer#ge…#6443
Open
tanishq-chugh wants to merge 2 commits intoapache:masterfrom
Open
HIVE-29551: Avoid quadratic runtime in ColumnStatsSemanticAnalyzer#ge…#6443tanishq-chugh wants to merge 2 commits intoapache:masterfrom
tanishq-chugh wants to merge 2 commits intoapache:masterfrom
Conversation
| if (typeInfo.getCategory() != ObjectInspector.Category.PRIMITIVE) { | ||
| logTypeWarning(colName, type); | ||
| } else { | ||
| nonPrimColNames.add(colName); |
Contributor
There was a problem hiding this comment.
the variable name should be PrimColNames instead of nonPrimColNames. As the primitve type will enter the else flow.
Contributor
Author
There was a problem hiding this comment.
@Aggarwal-Raghav My bad, i validated the columnTypes/names being returned for primitive types and used the wrong variable name. Updated in commit - 4a6804d .
Thanks for pointing this out !
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tColumnTypes
What changes were proposed in this pull request?
Improve time complexity in ColumnStatsSemanticAnalyzer#getColumnTypes
Why are the changes needed?
Performance Improvement
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual Testing + CI