Skip to content

HIVE-29568: Vectorized PTF is throwing RuntimeException#6437

Open
mdayakar wants to merge 1 commit intoapache:masterfrom
mdayakar:HIVE-29568_Vectorization
Open

HIVE-29568: Vectorized PTF is throwing RuntimeException#6437
mdayakar wants to merge 1 commit intoapache:masterfrom
mdayakar:HIVE-29568_Vectorization

Conversation

@mdayakar
Copy link
Copy Markdown
Contributor

HIVE-29568: Vectorized PTF is throwing RuntimeException

What changes were proposed in this pull request?

As a part of vectorized PTF execution, while finding the order by columns datatype when constant value is provided then some times like VOID, INTERVAL_DAY_TIME are missing so added them to support Vectorized PTF execution.

Why are the changes needed?

Can not use Vectorized PTF execution windowing function order by NULL or INTERVAL '1' DAY if the changes are not done.

Does this PR introduce any user-facing change?

No

How was this patch tested?

q file tests are added
mvn -Dtest=TestMiniLlapLocalCliDriver -Dqfile=vector_ptf_windowing_over_const.q -pl itests/qtest -Pitests

Copy link
Copy Markdown
Contributor

@thomasrebele thomasrebele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not an expert in vectorization, though.

Copy link
Copy Markdown
Contributor

@kasakrisz kasakrisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasakrisz
Copy link
Copy Markdown
Contributor

cc @abstractdog

@abstractdog
Copy link
Copy Markdown
Contributor

thanks for this patch so far @mdayakar ! I believe the q file would be a bit more valuable if it actually contains some rows, even if the original exception was handled
also in this case, a non-vectorized reference query is usually added for correctness sanity-check

@mdayakar
Copy link
Copy Markdown
Contributor Author

thanks for this patch so far @mdayakar ! I believe the q file would be a bit more valuable if it actually contains some rows, even if the original exception was handled also in this case, a non-vectorized reference query is usually added for correctness sanity-check

Thanks for the review @abstractdog , @thomasrebele and @kasakrisz
Fixed the comment given by @abstractdog , inserted some data and the results are compared with and without vectorized ptf execution.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants