fix(monitor): complete the missing help links in the monitoring template - #4389
Open
P-Peaceful wants to merge 3 commits into
Open
P-Peaceful wants to merge 3 commits into
P-Peaceful wants to merge 3 commits into
Conversation
utafrali
approved these changes
Sep 20, 2026
utafrali
left a comment
There was a problem hiding this comment.
Straightforward config-only change that adds missing helpLink entries to 11 monitoring templates, consistently following the existing zh-CN/en-US-only pattern seen in templates like app-linux.yml. The only concern is the S7 link pointing to documentation that doesn't exist yet.
| en-US: HertzBeat collects metrics related to maintaining registers and coils for services that support s7 protocol | ||
| zh-TW: HertzBeat對支持s7協定的服務進行(保持寄存器和線圈)相關名額進行採集 | ||
| ja-JP: HertzBeatはs7プロトコルをサポートするサービスのメトリクスを監視します。 | ||
| helpLink: |
There was a problem hiding this comment.
The S7 help documentation doesn't exist yet (acknowledged in the PR description), so both URLs here will return 404 until the follow-up PR lands. A dead link is a worse user experience than no link at all. Consider one of these approaches:
- Drop the
helpLinkblock from this file now and add it in the same PR that ships the S7 docs. - Or, if the docs page already exists in draft/stub form, verify the URLs resolve before merging.
Contributor
Author
There was a problem hiding this comment.
ok, i willed delete this helpLinke
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
helpLinkentries to 11 monitoring templates:Checklist
Add or update API
Testing
Not run. This is a configuration-only change that adds documentation links to monitoring templates.
Follow-up
The S7 monitoring help documentation is currently unavailable. I will add the missing S7 documentation in a subsequent PR.