HBASE-30332 Preserve QueryMetrics for empty results - #8555
Open
Sigma-Ma wants to merge 1 commit into
Open
Conversation
charlesconnell
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30332
What changes were proposed in this pull request?
This pull request preserves
QueryMetricswhen an emptyResultis converted to and from protobuf.The changes:
ProtobufUtil.toResultandProtobufUtil.toResultNoDatawhen the result contains no cells.Resultwhen deserializing a protobuf containing metrics, instead of attaching metrics to the shared cachedEMPTY_RESULT.No protobuf schema change is required.
Why are the changes needed?
When a
Getwith query metrics enabled requests a row that does not exist, the RegionServer still computes and attachesQueryMetrics, includingblockBytesScanned, to the emptyResult.However, the protobuf conversion methods returned cached empty protobuf instances before copying the metrics. As a result, the client received
result.getMetrics() == null.Simply preserving the metrics during serialization would also expose a second problem: the deserialization path could attach metrics to a shared cached empty
Result, potentially leaking those metrics into later requests where metrics were not enabled.These changes preserve the metrics while ensuring that metrics-bearing empty results are not shared between requests.
How was this patch tested?
The following focused test was run:
mvn -pl hbase-client -am \ -Dtest=TestProtobufUtil \ -Dsurefire.failIfNoSpecifiedTests=false \ test