HBASE-30043: Truncate procedure with recovery enabled could process non-existent regions if run concurrently with merge procedure#8003
Open
dParikesit wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Is it OK to just change holdLock to true for TruncationRegionProcedure? A region which is being truncating should not be able to be split or merge... |
vaijosh
approved these changes
Mar 30, 2026
Contributor
vaijosh
left a comment
vaijosh
left a comment
There was a problem hiding this comment.
Thanks @dParikesit for fixing this. Code changes LGTM.
Contributor
Author
|
Thanks for the suggestions. I'll try the holdLock fix and get back to you after I fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: HBASE-30043
During truncate recovery, the procedure can release the region lock between states. If that region gets merged away in that gap, the truncate procedure could still try to unassign/reassign or touch filesystem state for a region that no longer exists.
The proposed fix adds an existence check before MAKE_OFFLINE, centralizes region-node lookup in a helper that throws UnknownRegionException when the region is gone, and makes rollback only reassign if the region still exists and is in an offline/closed state.
The tests verify two things: truncate fails cleanly instead of recreating state or scheduling child procedures, and rollback also does not recreate the removed region or queue assigned work.