Skip to content

HBASE-30042 Test AuthUtil.loginClient with existing Kerberos login #8002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junegunn merged 2 commits into from
Mar 31, 2026
+37 −2
Merged

HBASE-30042 Test AuthUtil.loginClient with existing Kerberos login #8002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
307039e
HBASE-30042 Test AuthUtil.loginClient with existing Kerberos login
jinhyukify Mar 29, 2026
144f664
HBASE-30042 Fix test failure in TestUsersOperationsWithSecureHadoop
jinhyukify Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions ...r/src/test/java/org/apache/hadoop/hbase/security/TestUsersOperationsWithSecureHadoop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,15 @@ public class TestUsersOperationsWithSecureHadoop {

private static String CLIENT_NAME;

private static String OTHER_CLIENT_NAME;

@BeforeClass
public static void setUp() throws Exception {
KDC = TEST_UTIL.setupMiniKdc(KEYTAB_FILE);
PRINCIPAL = "hbase/" + HOST;
CLIENT_NAME = "foo";
KDC.createPrincipal(KEYTAB_FILE, PRINCIPAL, CLIENT_NAME);
OTHER_CLIENT_NAME = "bar";
KDC.createPrincipal(KEYTAB_FILE, PRINCIPAL, CLIENT_NAME, OTHER_CLIENT_NAME);
HBaseKerberosUtils.setPrincipalForTesting(PRINCIPAL + "@" + KDC.getRealm());
HBaseKerberosUtils.setKeytabFileForTesting(KEYTAB_FILE.getAbsolutePath());
HBaseKerberosUtils.setClientPrincipalForTesting(CLIENT_NAME + "@" + KDC.getRealm());
Expand Down Expand Up @@ -133,17 +136,49 @@ public void testLoginWithUserKeytabAndPrincipal() throws Exception {
}

@Test
public void testAuthUtilLogin() throws Exception {
public void testAuthUtilLoginWithExistingLoginUser() throws Exception {
Copy link
Copy Markdown
Contributor Author

@jinhyukify jinhyukify Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this test to only cover the case where a Kerberos user is already logged in.

String clientKeytab = getClientKeytabForTesting();
String clientPrincipal = getClientPrincipalForTesting();
Configuration conf = getSecuredConfiguration();
conf.set(AuthUtil.HBASE_CLIENT_KEYTAB_FILE, clientKeytab);
conf.set(AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL, clientPrincipal);
UserGroupInformation.setConfiguration(conf);

UserGroupInformation.loginUserFromKeytab(CLIENT_NAME, clientKeytab);

User user = AuthUtil.loginClient(conf);
assertTrue(user.isLoginFromKeytab());
assertEquals(CLIENT_NAME, user.getShortName());
assertEquals(getClientPrincipalForTesting(), user.getName());
}

@Test
public void testAuthUtilLoginWithDifferentExistingUser() throws Exception {
String clientKeytab = getClientKeytabForTesting();
String clientPrincipal = getClientPrincipalForTesting();
Configuration conf = getSecuredConfiguration();
conf.set(AuthUtil.HBASE_CLIENT_KEYTAB_FILE, clientKeytab);
conf.set(AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL, clientPrincipal);
UserGroupInformation.setConfiguration(conf);

// Login with other principal first
String otherPrincipal = OTHER_CLIENT_NAME + "@" + KDC.getRealm();
UserGroupInformation.loginUserFromKeytab(otherPrincipal, clientKeytab);

User user = AuthUtil.loginClient(conf);
assertTrue(user.isLoginFromKeytab());
// The existing login user (bar) doesn't match the principal configured in
// HBASE_CLIENT_KERBEROS_PRINCIPAL (foo), so loginClient should re-login
// with the configured principal.
assertEquals(CLIENT_NAME, user.getShortName());
assertEquals(getClientPrincipalForTesting(), user.getName());

conf.set(AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL, otherPrincipal);

user = AuthUtil.loginClient(conf);
assertTrue(user.isLoginFromKeytab());
// After updating HBASE_CLIENT_KERBEROS_PRINCIPAL to bar, loginClient should re-login with bar.
assertEquals(OTHER_CLIENT_NAME, user.getShortName());
assertEquals(otherPrincipal, user.getName());
}
}