Open
Conversation
Update all references to sf-hamilton package names to use the apache-hamilton prefix. Covers error messages, install instructions, requirements.txt files, notebooks, CI workflows, VSCode extension, and UI components. Import names are unchanged. The pyproject.toml extras for lsp/sdk/ui still point to sf-hamilton-* packages until stable apache-hamilton-* versions are published to PyPI.
- Point lsp/sdk/ui extras to sf-hamilton-* with TODO to switch once stable apache-hamilton-* versions are published to PyPI - Update ui/backend dependency from sf-hamilton to apache-hamilton - Disable ddtrace pytest plugin which spawns background threads that prevent clean process exit after the test suite completes
skrawcz
commented
Apr 26, 2026
|
|
||
| export const example2 = `from hamilton import driver | ||
| # pip install sf-hamilton-contrib==0.0.1rc1 | ||
| # pip install apache-hamilton-contrib==0.0.1rc1 |
Contributor
Author
There was a problem hiding this comment.
hmm maybe we just fix forward...
The contrib/docs project uses npm (has package-lock.json, no yarn.lock) but the workflow was using yarn with cache: yarn. This caused webpack Progress Plugin validation errors. Switch to npm ci for deterministic installs matching the lockfile.
c592e65 to
e9ddcb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename all
sf-hamiltonreferences toapache-hamiltonacross the repository.All 5 Hamilton packages were already migrated to flit +
apache-hamiltonprefix in theirpyproject.tomlfiles, but ~250 files still referenced the oldsf-hamiltonname indocumentation, examples, error messages, CI workflows, and other places. This PR updates them all for consistency.
What changed
hamilton/plugins/h_*.py,graph.py,cli, etc.) — error messages now saypip install apache-hamilton[...]docs/,README.md, package READMEs) — install instructions updatedrequirements.txt,.py,.ipynball referenceapache-hamiltonpyproject.toml—lsp/sdk/uiextras still point tosf-hamilton-*(only dev prereleases exist on PyPI for the apache-prefixed subpackages); TODO comments markthese for update once stable versions are published
ui/backend/pyproject.toml— dependency changed fromsf-hamiltontoapache-hamilton(stable 1.90.0 exists on PyPI)ddtraceauto-registers a pytest plugin that spawns background threads preventing clean process exit after the test suite. Disabling itfixes the test suite hang. Hamilton's own
DDOGTracertests are unaffected.scripts/find_hanging_tests.sh— new utility that runs each test file individually with a timeout to identify tests that prevent pytest from exitingWhat did NOT change
import hamilton,from hamilton.contrib import ...) — unchangedsf-hamilton-redirect/— intentionally references both names (it's the PyPI redirect package)scripts/generate_announce_email.py—sf-hamilton-tag matching for historical changelogscripts/README.md— documents the sf-hamilton redirect workflowTest plan
uv syncresolves cleanlysf-hamiltonreferences remain (3 files)apache-hamilton[visualization]extra resolves from PyPIChecklist