Skip to content

[GLUTEN-6887][VL] Re-enable decimal tests #12949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rui-mo wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −10
Open

[GLUTEN-6887][VL] Re-enable decimal tests #12949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...ds-velox/src/test/scala/org/apache/gluten/execution/VeloxOrcDataTypeValidationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,11 +429,7 @@ class VeloxOrcDataTypeValidationSuite extends VeloxWholeStageTransformerSuite {
" type2 where type1.struct.struct_1 = type2.struct.struct_1") { _ => }
}

// TODO: Re-enable once Velox implements HugeintValuesUsingHashTable::mergeWith.
// The hash join on decimal(38, 18) pushes a hugeint dynamic filter into the scan
// (velox#18159), and merging it with the existing IsNotNull filter throws
// "mergeWith() is not supported".
ignore("Decimal type") {
test("Decimal type") {
Comment thread
rui-mo marked this conversation as resolved.
// Validation: BatchScan Project Aggregate Expand Sort Limit
runQueryAndCompare(
"select int, decimal from type1 " +
Expand Down
6 changes: 1 addition & 5 deletions ...elox/src/test/scala/org/apache/gluten/execution/VeloxParquetDataTypeValidationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,7 @@ class VeloxParquetDataTypeValidationSuite extends VeloxWholeStageTransformerSuit
" type2 where type1.struct.struct_1 = type2.struct.struct_1") { _ => }
}

// TODO: Re-enable once Velox implements HugeintValuesUsingHashTable::mergeWith.
// The hash join on decimal(38, 18) pushes a hugeint dynamic filter into the scan
// (velox#18159), and merging it with the existing IsNotNull filter throws
// "mergeWith() is not supported".
ignore("Decimal type") {
test("Decimal type") {
Comment thread
rui-mo marked this conversation as resolved.
// Validation: BatchScan Project Aggregate Expand Sort Limit
runQueryAndCompare(
"select int, decimal from type1 " +
Expand Down
Loading