Skip to content

fix: support deep copy in GraalVM #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jahnvichaudhary wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: support deep copy in GraalVM #4147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4e6e56
fix: eagerly initialize object serializer field infos
jahnvichaudhary Oct 8, 2026
bb8a28f
Revert "fix: eagerly initialize object serializer field infos"
jahnvichaudhary Oct 8, 2026
1a39b94
fix: eagerly build field infos for graalvm
jahnvichaudhary Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions java/fory-core/src/main/java/org/apache/fory/serializer/AbstractObjectSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

package org.apache.fory.serializer;

import org.apache.fory.platform.GraalvmSupport;

import java.lang.reflect.Array;
import java.lang.reflect.Field;
import java.lang.reflect.Modifier;
Expand Down Expand Up @@ -109,6 +111,9 @@ public AbstractObjectSerializer(
this.isRecord = RecordUtils.isRecord(type);
this.objectInstantiator = objectInstantiator;
this.objectGraphMemoryBytes = GraphMemoryEstimates.shallowObjectBytes(type);
if (GraalvmSupport.isGraalBuildTime()) {
buildFieldsInfo();
}
}

// Keep exception construction and message formatting off the field write success path.
Expand Down Expand Up @@ -1099,6 +1104,10 @@ private Object copyNotPrimitiveField(
return copyFieldValue(copyContext, fieldAccessor.getObject(targetObject), typeId);
}

void setFieldInfos(SerializationFieldInfo[] fieldInfos) {
this.fieldInfos = fieldInfos;
}

private SerializationFieldInfo[] buildFieldsInfo() {
List<Descriptor> descriptors = new ArrayList<>();
if (RecordUtils.isRecord(type)) {
Expand Down
3 changes: 2 additions & 1 deletion java/fory-core/src/main/java/org/apache/fory/serializer/ObjectSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ public ObjectSerializer(
}
FieldGroups fieldGroups = FieldGroups.buildFieldInfos(typeResolver, grouper);
allFields = fieldGroups.allFields;
setFieldInfos(allFields);
}

@Override
Expand Down Expand Up @@ -337,4 +338,4 @@ public static void checkClassVersion(Class<?> cls, int readHash, int classVersio
cls, readHash, classVersionHash));
}
}
}
}
Loading