Skip to content

[CI] Stabilize Netty client disconnection test - #4344

Open
litiliu wants to merge 1 commit into
apache:mainfrom
litiliu:codex/fix-netty-client-disconnection-test
Open

litiliu wants to merge 1 commit into
apache:mainfrom
litiliu:codex/fix-netty-client-disconnection-test

Conversation

@litiliu

@litiliu litiliu commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
  • No generative AI tools used
  • Yes (Codex)

Generated-by: Codex following the Apache Fluss guidelines

Purpose

Linked issue: close #4346

NettyClientTest.testServerDisconnection immediately checks the connection map after a failed request completes. The request future can complete before the asynchronous close callback removes the disconnected connection, making the test flaky with expected: 0 but was: 1.

Brief change log

  • Retry the existing AssertJ assertion until the asynchronous connection cleanup completes.
  • Keep production connection behavior unchanged.

Tests

  • ./mvnw -pl fluss-rpc -am -DskipITs test
  • 10 consecutive runs of NettyClientTest#testServerDisconnection
  • ./mvnw -pl fluss-rpc spotless:check checkstyle:check

API and Format

No API or storage format changes.

Documentation

No documentation changes.

@litiliu litiliu changed the title [test] Stabilize Netty client disconnection test [rpc] Stabilize Netty client disconnection test Sep 15, 2026
@litiliu litiliu changed the title [rpc] Stabilize Netty client disconnection test [CI] Stabilize Netty client disconnection test Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] NettyClientTest.testServerDisconnection is flaky

1 participant