[rust] Add into_stream() to bounded readers#3664
Merged
Merged
Conversation
fresh-borzoni
force-pushed
the
rust-into-stream
branch
from
July 16, 2026 02:44
daaf475 to
b8bd7d6
Compare
Member
Author
|
@beryllw PTAL 🙏 |
Contributor
|
LGTM, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3665
Adds into_stream(self) -> impl Stream<Item = Result> to RecordBatchLogReader and LimitBatchScanner.
A try_unfold over the existing next_batch(), so async consumers (DataFusion) can drive the bounded readers as a Stream.
Yields ScanBatch (keeps bucket/offset) and stays a plain futures::Stream, no datafusion dep in core, so the caller wraps it.
Dropping the stream reuses the reader's existing cleanup.