Skip to content

FINERACT-2421: Allow using Mysql / Mariadb db clients for development…#6004

Open
adamsaghy wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2421/allow-to-use-mysql-driver-for-development
Open

FINERACT-2421: Allow using Mysql / Mariadb db clients for development…#6004
adamsaghy wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2421/allow-to-use-mysql-driver-for-development

Conversation

@adamsaghy

Copy link
Copy Markdown
Contributor

… (devRun/bootRun)

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy

Copy link
Copy Markdown
Contributor Author

@SamaSVM @meonkeys Can you please take a look at this whether it is something we can do?

@meonkeys meonkeys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Dev only should be fine. According to FINERACT-2572, as long as we don't ship category X drivers we are good. Meaning, they can't be in apache-fineract-bin-$VERSION.tar.gz, and they can only be in the Docker image if they're added similar to how you might install an OS package (e.g. apt-get install libfoo).

I just ran ./gradlew srcDistTar binaryDistTar -x test and inspected fineract-war/build/distributions/apache-fineract-bin-1.15.0-SNAPSHOT.tar.gz. That tarball has fineract-provider-1.15.0-SNAPSHOT.jar and that jar has only BOOT-INF/lib/postgresql-42.7.11.jar. So I think the binary release will be clean.

To check the Docker image I built with ./gradlew jibDockerBuild then started a container with

docker run --rm -it --entrypoint sh fineract

I poked around in the container and the only db driver I see is /app/libs/postgresql-42.7.11.jar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants