Skip to content

fix: prevent CSV multi-sheet data loss - #1158

Open
Aias00 wants to merge 1 commit into
apache:mainfrom
Aias00:fix/csv-multi-sheet-loss-1148
Open

Aias00 wants to merge 1 commit into
apache:mainfrom
Aias00:fix/csv-multi-sheet-loss-1148

Conversation

@Aias00

@Aias00 Aias00 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Closed: #1148

Summary

  • reject creation of a second CSV sheet at runtime instead of relying on disabled assertions
  • add a regression test that preserves the first sheet data after the second-sheet write is rejected

Verification

  • ./mvnw -pl fesod-sheet -Dmaven.test.skip=false -DskipTests=false -Dtest=CsvFormatTest#writeSecondCsvSheetShouldFailWithoutLosingFirstSheetData test
  • ./mvnw -pl fesod-sheet spotless:check

Signed-off-by: liuhy <liuhongyu@apache.org>
@Aias00
Aias00 force-pushed the fix/csv-multi-sheet-loss-1148 branch from 687f71a to 8597fad Compare September 30, 2026 07:03

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Writing multiple sheets to CSV silently drops unflushed rows

1 participant