Skip to content

[improvement](lance) Update lance-c to upstream search filters - #68776

Merged
yiguolei merged 2 commits into
apache:masterfrom
zhangstar333:lance-patch-update
Oct 9, 2026
Merged

yiguolei merged 2 commits into
apache:masterfrom
zhangstar333:lance-patch-update

Conversation

@zhangstar333

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:
lance-format/lance-c#91

Include Lance-C vector post-filtering and scoped FTS prefiltering improvements.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

### What problem does this PR solve?

Issue Number: N/A

Related PR: N/A

Problem Summary: Doris pinned lance-c at 98468344bc9d56aa7ed4a4192e844afa62b34ba1 and missed upstream apache#91 vector post-filtering and scoped FTS prefiltering. Pin the dependency to 8e9e09ecc795c91ce7f97513db94c2d91eec799d, update the archive checksum, and regenerate the local Foyer patch against the new base while keeping its implementation unchanged.

### Release note

Include Lance-C vector post-filtering and scoped FTS prefiltering improvements.

### Check List (For Author)

- Test: Static dependency validation: shell syntax checks, archive checksum validation, strict patch application, isolated downloader idempotence and source-tree comparison. No Doris build or unit/regression tests run.
- Behavior changed: Yes; adopts upstream Lance-C apache#91 search-filter behavior.
- Does this need documentation: No
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333

Copy link
Copy Markdown
Contributor Author

run buildall

### What problem does this PR solve?

Issue Number: N/A

Related PR: lance-format/lance-c#73

Problem Summary: Doris carried an older local Foyer patch. Refresh it from the current PR head 8a08f171b66a3e01e7ba634bcfc6168a955c7289 and rebase it onto the pinned Lance-C commit 8e9e09ecc795c91ce7f97513db94c2d91eec799d, preserving the newer upstream search and prewarm changes. The PR head includes its revert of the interim cache-origin-isolation change.

### Release note

Update the bundled Lance-C Foyer cache integration to match upstream PR apache#73.

### Check List (For Author)

- Test: Static validation: strict patch application, downloader refresh, isolated repeated downloader run, source-tree comparison, shell syntax, and diff checks. No build or tests run.
- Behavior changed: Yes; the bundled Foyer implementation now matches the current PR head, including its cache-origin-isolation revert.
- Does this need documentation: No
@zhangstar333

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.56% (35034/45759)
Line Coverage 61.77% (395994/641067)
Region Coverage 58.17% (333878/573938)
Branch Coverage 59.11% (153706/260049)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.56% (35034/45759)
Line Coverage 61.77% (395992/641067)
Region Coverage 58.17% (333877/573938)
Branch Coverage 59.11% (153703/260049)

@yiguolei
yiguolei merged commit ee42e4d into apache:master Oct 9, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants