Conversation
### What problem does this PR solve?
Issue Number: N/A
Problem Summary: split_by_regexp advanced one byte at a time for an empty pattern, so multibyte UTF-8 characters were split into invalid array elements. Advance by the current UTF-8 code point length and add regression coverage with and without a split limit.
### Release note
Fix split_by_regexp with an empty pattern to split UTF-8 strings by character instead of by byte.
### Check List (For Author)
- Test: Regression test
- RELEASE BE build and targeted test_split_by_regexp regression
- Behavior changed: Yes; empty-pattern splitting now preserves UTF-8 character boundaries.
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split_by_regexpadvanced one byte at a time when the pattern was empty, which split multibyte UTF-8 characters into invalid array elements and could truncate a character when a limit was specified. Root cause: the empty-pattern path bypassed RE2 and treated each byte as a complete character. The implementation now advances by the current UTF-8 code point length while preserving the existing byte-based behavior for ASCII input. Regression coverage verifies Chinese and emoji input with and without a split limit.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)