[chore](build) Require code-owner approval for branch-4.2 PRs - #68014
Open
hello-stephen wants to merge 1 commit into
Open
hello-stephen wants to merge 1 commit into
hello-stephen wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: N/A Problem Summary: branch-4.2 has a sole CODEOWNER but is not protected, so its pull requests can be merged without code-owner approval. Add the same required review policy used by branch-4.1 to the ASF-managed protected branch configuration. ### Release note None ### Check List (For Author) - Test: Manual test — parsed .asf.yaml and asserted the branch-4.2 review policy matches branch-4.1; git diff --check passed. - Behavior changed: Yes — branch-4.2 PRs will require code-owner approval after ASF sync. - Does this need documentation: No
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
added a commit
that referenced
this pull request
Sep 15, 2026
## Background Release-branch GitHub Actions are frequently queued, including redundant post-merge runs and a thirdparty change detector on unrelated PRs. ## Changes - Remove the duplicate Check Large File push trigger; keep pull_request_target. - Remove the legacy Need_2_Approval workflow. The Code Owner approval policy is tracked separately in #68014; this PR does not change it. - Start Build Third Party Libraries on PRs only when its relevant inputs change. Keep workflow_dispatch and issue_comment triggers. ## Scope note Code Checks is unchanged; its push trigger optimization is deferred for separate review. External Regression's regression-test/pipeline/external/conf/fe.conf is excluded from both the PR entry filter and the old focused test filter. A change to that file alone will no longer trigger Thirdparty Script Test or its ADBC JNI assertion. The assertion still runs when a thirdparty-related change triggers the script test; this PR does not move it to another workflow. ## Validation - actionlint passed for all edited workflow files (excluding pre-existing inline shellcheck and old-runner warnings). - git diff --check passed. - The currently configured branch-4.2 governance does not require these Actions as checks; this PR does not change that policy. No TeamCity pipeline or branch governance configuration is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary: Apache Doris manages branch protection through the ASF-synced
.asf.yaml. Thebranch-4.1entry requires one approving Code Owner review and dismisses stale approvals, butbranch-4.2is absent and currently reportsprotected: falseeven though its CODEOWNERS file contains* @yiguolei. Add the same review policy forbranch-4.2so its PRs require yiguolei approval once ASF synchronizes the merged configuration.This PR intentionally adds only the requested review gate. It does not invent a required CI context list for 4.2; that should be added separately after checking which 4.2 contexts are consistently published.
Release note
None
Check List (For Author)
git diff --checkpassed.