Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
The MergedProfile parser reads every PlanInfo line and counter an operator
reports, but three defects lose or corrupt part of it, and the rest is thrown
away before the graph IR is built.
- A parenthesised table name loses its closing parenthesis:
table_name=item(item) becomes "item(item". TABLE_NAME_RE excluded "," and
")" but not "(", so the greedy match ran past the opening parenthesis. The
name is shown in the operator details and used by the graph search.
- Counter keys could not contain a space, so every counter nested under a
parent failed to match and the whole RuntimeFilterInfo subtree was dropped.
Nested counters are now kept, keyed "parent/child" by indentation.
- PLAN_INFO_WHITELIST omitted PREDICATES, tablets, pushAggOp, PREAGGREGATION,
TOPN OPT and projections, and a line carrying two pairs
("TABLE: t, PREAGGREGATION: ON") leaked the second pair into the first value.
On the captured TPC-DS query 41 scan, the "Plan information" section of the
operator details goes from three rows, one of them wrong, to nine correct rows,
including the predicates and the tablets read.
Each node also keeps all its counters now, and two derived fields turn text
into numbers: planFacts (estimated rows, partitions and tablets selected out of
total, pushAggOp, preAggregation, predicates) and runtimeFilters (input,
filtered and always-true rows per filter). Nothing renders them yet; they are
the input for the diagnostics that follow. The rendered metrics are unchanged.
yx-keith
force-pushed
the
ui-profile-parser-fix
branch
from
September 15, 2026 06:41
31bed65 to
1e9d771
Compare
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MergedProfile parser reads every PlanInfo line and counter an operator reports, but three defects lose or corrupt part of it, and the rest is thrown away before the graph IR is built.
On the captured TPC-DS query 41 scan, the "Plan information" section of the operator details goes from three rows, one of them wrong, to nine correct rows, including the predicates and the tablets read.
Each node also keeps all its counters now, and two derived fields turn text into numbers: planFacts (estimated rows, partitions and tablets selected out of total, pushAggOp, preAggregation, predicates) and runtimeFilters (input, filtered and always-true rows per filter). Nothing renders them yet; they are the input for the diagnostics that follow. The rendered metrics are unchanged.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)