Skip to content

[fix](be) Initialize JNI split read options in test#65544

Merged
hello-stephen merged 1 commit into
apache:masterfrom
Gabriel39:gabriel/fix-jni-split-read-options
Jul 13, 2026
Merged

[fix](be) Initialize JNI split read options in test#65544
hello-stephen merged 1 commit into
apache:masterfrom
Gabriel39:gabriel/fix-jni-split-read-options

Conversation

@Gabriel39

@Gabriel39 Gabriel39 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Fix a BE UT compile failure introduced by the combination of #65500 and #65503.
SplitReadOptions now has conjuncts and all_runtime_filters_applied, while
the new jni_table_reader_test.cpp designated initializer did not initialize
them. With -Werror,-Wmissing-designated-field-initializers, this fails
compilation.

This PR explicitly initializes the two fields in the test and adds the missing
<optional> include for std::nullopt.

Release note

None

Check List (For Author)

  • Test: Unit Test
    • ./run-be-ut.sh --run --filter=JniTableReaderTest.* on gabriel@10.26.20.3
      in /mnt/disk3/gabriel/tmp/doris-fix-jni-split-read-options: 5 tests passed.
  • Behavior changed: No
  • Does this need documentation: No

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 30097 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 748dd54caa6f63d0741577cf6450af2b4fa79537, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17643	4298	4243	4243
q2	2010	323	204	204
q3	10300	1462	845	845
q4	4677	479	345	345
q5	7526	858	569	569
q6	183	181	145	145
q7	777	848	627	627
q8	9386	1675	1594	1594
q9	5657	4356	4391	4356
q10	6778	1827	1543	1543
q11	509	351	308	308
q12	724	571	441	441
q13	18063	3429	2764	2764
q14	272	266	243	243
q15	q16	785	783	713	713
q17	1031	956	1050	956
q18	7043	5741	5613	5613
q19	1301	1350	1053	1053
q20	760	631	535	535
q21	6197	2876	2688	2688
q22	466	371	312	312
Total cold run time: 102088 ms
Total hot run time: 30097 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5290	4933	5042	4933
q2	292	351	215	215
q3	4921	5321	4727	4727
q4	2074	2134	1389	1389
q5	5024	4707	4704	4704
q6	256	187	139	139
q7	1947	1811	1539	1539
q8	2585	2174	2147	2147
q9	7925	7293	7360	7293
q10	4666	4698	4228	4228
q11	524	385	351	351
q12	749	763	541	541
q13	2987	3411	2780	2780
q14	279	289	263	263
q15	q16	672	694	606	606
q17	1266	1241	1237	1237
q18	7139	6767	6799	6767
q19	1099	1080	1067	1067
q20	2208	2211	1933	1933
q21	5215	4504	4395	4395
q22	509	459	414	414
Total cold run time: 57627 ms
Total hot run time: 51668 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 179692 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 748dd54caa6f63d0741577cf6450af2b4fa79537, data reload: false

query5	4352	643	485	485
query6	454	221	210	210
query7	4883	623	335	335
query8	336	185	179	179
query9	8773	3995	4031	3995
query10	478	338	304	304
query11	5834	2328	2153	2153
query12	176	106	102	102
query13	1298	613	444	444
query14	6249	5296	4966	4966
query14_1	4303	4276	4284	4276
query15	210	203	180	180
query16	991	481	465	465
query17	1152	701	563	563
query18	2470	447	339	339
query19	204	184	139	139
query20	114	109	105	105
query21	223	154	128	128
query22	13623	13718	13377	13377
query23	17451	16476	16158	16158
query23_1	16308	16221	16166	16166
query24	7708	1759	1300	1300
query24_1	1280	1303	1276	1276
query25	557	434	360	360
query26	1362	337	206	206
query27	2597	625	372	372
query28	4429	2035	1999	1999
query29	1055	633	479	479
query30	337	267	229	229
query31	1112	1081	987	987
query32	114	60	61	60
query33	509	317	245	245
query34	1159	1156	662	662
query35	769	788	656	656
query36	1437	1392	1214	1214
query37	147	107	90	90
query38	1864	1722	1596	1596
query39	920	945	909	909
query39_1	891	886	876	876
query40	250	172	142	142
query41	73	70	70	70
query42	103	97	95	95
query43	321	333	284	284
query44	1431	795	794	794
query45	200	205	184	184
query46	1063	1233	771	771
query47	2400	2350	2238	2238
query48	417	417	288	288
query49	580	444	323	323
query50	1076	422	341	341
query51	10746	10976	10533	10533
query52	88	90	75	75
query53	261	294	205	205
query54	313	261	238	238
query55	84	76	68	68
query56	314	303	286	286
query57	1431	1405	1348	1348
query58	288	284	281	281
query59	1583	1628	1450	1450
query60	313	279	262	262
query61	171	171	173	171
query62	710	650	588	588
query63	237	207	205	205
query64	2956	1110	837	837
query65	4892	4782	4778	4778
query66	1822	503	382	382
query67	29470	29481	29298	29298
query68	3011	1609	1017	1017
query69	415	290	270	270
query70	1045	972	939	939
query71	356	317	310	310
query72	3050	2728	2406	2406
query73	836	795	415	415
query74	5118	4989	4799	4799
query75	2611	2585	2238	2238
query76	2336	1163	811	811
query77	364	388	279	279
query78	12345	12279	11745	11745
query79	1370	1145	762	762
query80	1280	518	465	465
query81	516	329	293	293
query82	628	160	120	120
query83	388	320	294	294
query84	272	160	128	128
query85	967	586	526	526
query86	416	287	280	280
query87	1849	1820	1756	1756
query88	3679	2784	2777	2777
query89	450	412	367	367
query90	1963	202	192	192
query91	199	180	160	160
query92	63	61	55	55
query93	1653	1644	977	977
query94	724	367	326	326
query95	780	493	460	460
query96	1110	791	357	357
query97	2681	2686	2560	2560
query98	212	212	201	201
query99	1127	1168	1039	1039
Total cold run time: 265862 ms
Total hot run time: 179692 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 24.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 748dd54caa6f63d0741577cf6450af2b4fa79537, data reload: false

query1	0.01	0.01	0.00
query2	0.10	0.05	0.04
query3	0.25	0.14	0.14
query4	1.62	0.14	0.14
query5	0.24	0.26	0.22
query6	1.22	1.03	1.05
query7	0.04	0.01	0.01
query8	0.06	0.04	0.04
query9	0.38	0.32	0.32
query10	0.54	0.55	0.55
query11	0.20	0.14	0.13
query12	0.19	0.15	0.14
query13	0.46	0.47	0.47
query14	1.02	1.00	1.01
query15	0.62	0.59	0.60
query16	0.32	0.33	0.30
query17	1.12	1.07	1.11
query18	0.22	0.20	0.22
query19	2.04	1.98	1.93
query20	0.02	0.02	0.01
query21	15.44	0.20	0.13
query22	4.94	0.05	0.05
query23	16.16	0.31	0.13
query24	2.93	0.41	0.31
query25	0.11	0.05	0.03
query26	0.76	0.20	0.14
query27	0.05	0.03	0.04
query28	3.55	0.95	0.53
query29	12.48	4.15	3.28
query30	0.27	0.15	0.15
query31	2.77	0.60	0.32
query32	3.23	0.60	0.49
query33	3.18	3.21	3.15
query34	15.49	4.24	3.47
query35	3.58	3.57	3.50
query36	0.56	0.45	0.41
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.16	0.16
query41	0.08	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 96.69 s
Total hot run time: 24.81 s

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.00% (23628/41456)
Line Coverage 40.68% (231233/568430)
Region Coverage 36.56% (182664/499590)
Branch Coverage 37.68% (81656/216726)

@hello-stephen

Copy link
Copy Markdown
Contributor

skip buildall

@hello-stephen hello-stephen merged commit a37667d into apache:master Jul 13, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants