Skip to content

branch-4.0: [fix](recycler) skip packed slice deletion during recycle rowsets#65534

Merged
morningman merged 1 commit into
apache:branch-4.0from
wyxxxcat:filter_packed_file_4_0
Jul 14, 2026
Merged

branch-4.0: [fix](recycler) skip packed slice deletion during recycle rowsets#65534
morningman merged 1 commit into
apache:branch-4.0from
wyxxxcat:filter_packed_file_4_0

Conversation

@wyxxxcat

Copy link
Copy Markdown
Collaborator

pick: #63295

@wyxxxcat wyxxxcat requested a review from morningman as a code owner July 13, 2026 08:48
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat

Copy link
Copy Markdown
Collaborator Author

run buildall

@wyxxxcat

Copy link
Copy Markdown
Collaborator Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two issues in the packed-slice recycler changes. The main correctness issue is that packed partial-update rowsets still go through raw prefix deletion, and there is also a batch metrics regression for all-packed rowsets. No additional user focus was provided. I could not load a repository-local code-review SKILL.md in this checkout, so the review followed the prepared prompt workflow, current repo evidence, and two rounds of real subagent convergence.

Comment thread cloud/src/recycler/recycler.cpp
Comment thread cloud/src/recycler/recycler.cpp
@morningman morningman merged commit e4932ef into apache:branch-4.0 Jul 14, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants