[Improvement-18593] [API&DAO] Optimize TaskInstanceMapper to exclude large text fields from list queries - #18595
Open
njnu-seafish wants to merge 2 commits into
Open
[Improvement-18593] [API&DAO] Optimize TaskInstanceMapper to exclude large text fields from list queries#18595njnu-seafish wants to merge 2 commits into
njnu-seafish wants to merge 2 commits into
Conversation
njnu-seafish
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
August 27, 2026 06:21
ruanwenjun
requested changes
Aug 27, 2026
ruanwenjun
left a comment
Member
There was a problem hiding this comment.
Please provide benchmark results to show exactly how much performance this type of refactoring can improve. Otherwise, we should return all fields in Listing interface, rather than add new VO/DTO.
|
|
||
| private int pid; | ||
|
|
||
| private String appLink; |
Member
There was a problem hiding this comment.
Remove the text column at listing api.
Contributor
Author
There was a problem hiding this comment.
Remove the text column at listing api.
Sorry, I'm not quite sure I understand this review comment. I've already run the SQL benchmark with large fields excluded.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Was this PR generated or assisted by AI?
YES. Leverage LLMs to verify that the removed large text fields are indeed unused.
Purpose of the pull request
close #18593
Brief change log
Optimize TaskInstanceMapper to exclude large text fields from list queries
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md