[Chore][Common] Correct Windows user list separator parsing#18413
Closed
hiSandog wants to merge 1 commit into
Closed
[Chore][Common] Correct Windows user list separator parsing#18413hiSandog wants to merge 1 commit into
hiSandog wants to merge 1 commit into
Conversation
e245114 to
2f87e20
Compare
Member
|
As the official document said, we only support MacOS and Linux, and there is no plan to support Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES. Codex assisted with identifying the indexing bug, implementing the fix, and adding the regression test.
Purpose of the pull request
The Windows net user parser checks charAt(i) inside a loop over j. A line that starts with a hyphen can therefore be misclassified as the all-hyphen separator, causing header text to be returned as usernames. The parser also needs to handle the CRLF output preserved by ShellExecutor.
Brief change log
Verify this pull request
This change added tests and can be verified as follows: