fix(dora): ignore seed deployments in change lead time lookup#8929
Open
bujjibabukatta wants to merge 1 commit into
Open
fix(dora): ignore seed deployments in change lead time lookup#8929bujjibabukatta wants to merge 1 commit into
bujjibabukatta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8790.
This updates the DORA change lead time deployment lookup so seed deployments are not used as valid deployment references for historical merge requests. The query now requires the deployment to have an actual previous deployment commit and joins
commits_diffsagainst that previous commit SHA, instead of treating an empty previous commit as a valid range boundary.This prevents the first recorded deployment for a project from being associated with old MRs when historical MR data exists but historical deployment data does not.