Skip to content

chore: remove incomplete examples module #114

Merged
PsiACE merged 1 commit intoapache:mainfrom
caicancai:remove-examples-module
Apr 10, 2026
Merged

chore: remove incomplete examples module #114
PsiACE merged 1 commit intoapache:mainfrom
caicancai:remove-examples-module

Conversation

@caicancai
Copy link
Copy Markdown
Member

close #112

@caicancai caicancai marked this pull request as draft April 10, 2026 14:42
The examples module was incomplete and not present in other DataSketches
dialect libraries. Basic usage examples are better served by rustdoc
examples directly in the code.
@caicancai caicancai force-pushed the remove-examples-module branch from ec5da5d to 8c8bdac Compare April 10, 2026 14:43
@caicancai caicancai marked this pull request as ready for review April 10, 2026 14:48
@caicancai
Copy link
Copy Markdown
Member Author

caicancai commented Apr 10, 2026

cc @notfilippo @PsiACE

Copy link
Copy Markdown
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PsiACE PsiACE merged commit 6dbe414 into apache:main Apr 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The necessity of the Example module

2 participants