feat: complete range repartition physical planning#23617
Open
saadtajwar wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
cc @gene-bordegaray & @gabotechs ! Thanks in advance for any feedback! 😁 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
After #23231 was merged in for supporting physical execution of the range repartitioning scheme, we still had a few methods on physical planning unimplemented, specifically
try_swapping_with_projection,try_pushdown_sort,repartitioned- this PR finishes the implementation of those methodsWhat changes are included in this PR?
try_swapping_with_projection: similar to theHashscheme, forRangewe callupdate_exprfor each of the range key expressions to attempt rewriting based on the projection expressionstry_pushdown_sort: same as other variants, we delegate to the child and wrap with a newRepartitionExecrepartitioned: unable to support for Range, left comment in codebase with explanationAre these changes tested?
Yes
Are there any user-facing changes?
No