Draft: implement non-blocking morsel API#21852
Draft
alamb wants to merge 12 commits intoapache:mainfrom
Draft
Conversation
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
poll_scanloop into separate functions to reduce the indent level / control flowWhich issue does this PR close?
Rationale for this change
In #21342 (comment), @adriangb pointed out that the current Morsel API relied on a comment rather than they typesystem to separate IO and CPU.
Also, it should be pointed out that the current Parquet opener actually does now do IO in the stream reader. This makes overlapping the IO and CPU harder
What changes are included in this PR?
It would be nice to
2. Make the morsel API harder to misuse
I don't expect this change will have much of an actual impact (yet) but I do expect that it will set us up for better IO interleaving
Are these changes tested?
yes by CI and new tests (to be written)
Are there any user-facing changes?
The unreleased Morsel API is slightly different