chore: bump sha & md-5 to 0.11.0#21840
Merged
alamb merged 2 commits intoapache:mainfrom Apr 27, 2026
Merged
Conversation
Weijun-H
reviewed
Apr 26, 2026
| macro_rules! digest_to_array { | ||
| ($METHOD:ident, $INPUT:expr) => {{ | ||
| ($MODULE:ident, $METHOD:ident, $INPUT:expr) => {{ | ||
| use $MODULE::Digest; |
Member
There was a problem hiding this comment.
nit:
This is a reasonable way to handle the mixed digest versions. Another readability option would be to use UFCS, e.g. <$METHOD as $MODULE::Digest>::digest(...), so the trait version is explicit at the call site. Not necessary for this PR.
Contributor
Author
There was a problem hiding this comment.
Thats a nice idea, though I think it makes it a bit more verbose, e.g.
ScalarValue::Binary(
$INPUT.map(|v| <$METHOD as $MODULE::Digest>::digest(v).as_slice().to_vec()),
)
Weijun-H
approved these changes
Apr 26, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Keep dependencies up to date.
What changes are included in this PR?
We used to use
Digestfromblake2, which was a common dependency used bymd5andsha2; howeverblake2doesn't have a0.11.0release so we were blocked because of incompatible dependencies when trying to upgradesha2ormd5. Fix code to use their ownDigest(e.g.md5::Digest,sha2::Digest) instead of relying onblake2::Digestwhich should prevent such issues from occurring again and allows us to bump their versions independently.Are these changes tested?
Existing tests.
Are there any user-facing changes?
No.