minor: More comments to read_spill_as_stream#21713
Merged
2010YOUY01 merged 2 commits intoapache:mainfrom Apr 20, 2026
Merged
Conversation
comphead
reviewed
Apr 18, 2026
| /// Reads a spill file as a stream. The file must be created by the current `SpillManager`. | ||
| /// This method will generate output in FIFO order: the batch appended first | ||
| /// will be read first. | ||
| /// Reads a spill file as a stream. The file must be created by the current |
Contributor
There was a problem hiding this comment.
what would happen if file created by another SpillManager? would the file be ignored or crash?
Contributor
Author
There was a problem hiding this comment.
I looked at the code—it appears to succeed silently, and error would be propagated to the stream consumer due to a schema mismatch.
I’ve updated the comment to indicate this may lead to undefined behavior.
We could be more defensive here; I’ll send a follow-up patch to make it fail fast.
Rich-T-kid
pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Clarifying a function with more comments ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Clarifying a function with more comments
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?