[datafusion-spark] Support 2-argument ceil(value, scale)#21710
Open
diegoQuinas wants to merge 3 commits intoapache:mainfrom
Open
[datafusion-spark] Support 2-argument ceil(value, scale)#21710diegoQuinas wants to merge 3 commits intoapache:mainfrom
diegoQuinas wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #21560
Rationale for this change
The Spark
ceilfunction supports an optionalscaleparameter that controlsthe decimal position to round up to. This was not yet implemented in
datafusion-spark.
What changes are included in this PR?
Signatureto accept 1 or 2 arguments, following the same pattern asSparkRoundreturn_type: floats preserve their type when a scale is provided (instead of returningInt64); scale=0 preserves the original behaviorget_scale()helper to extract the optional scale argument, returningNonefor NULL scale (which produces a NULL result)ceil_float()helper for ceiling floats at arbitrary decimal positionsspark_ceil_scalarandspark_ceil_arrayto apply the scaleAre these changes tested?
Yes, unit tests covering:
Are there any user-facing changes?
Yes —
ceil(expr, scale)is now supported in addition to the existingceil(expr).