chore: Rename concat-specific string builders, make pub(crate)#21695
Open
neilconway wants to merge 2 commits intoapache:mainfrom
Open
chore: Rename concat-specific string builders, make pub(crate)#21695neilconway wants to merge 2 commits intoapache:mainfrom
neilconway wants to merge 2 commits intoapache:mainfrom
Conversation
Rename the three builders in `datafusion/functions/src/strings.rs` to make their special-purpose nature explicit: - `StringArrayBuilder` -> `ConcatStringBuilder` - `LargeStringArrayBuilder` -> `ConcatLargeStringBuilder` - `StringViewArrayBuilder` -> `ConcatStringViewBuilder` These builders are used only by `concat` and `concat_ws`, and their API is specific enough to the requirements of `concat`-like callers that it seems unlikely that other call-sites will develop in the future. This also frees the previous names of these builders to be used by a more broadly useful string builder API. Also make these types `pub(crate)`, instead of `pub`; there is no good reason to make them part of the public API. This is a breaking API change.
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
StringViewArrayBuilderand related types #21684 but does not close it.Rationale for this change
Rename the three builders in
datafusion/functions/src/strings.rsto make their special-purpose nature explicit:StringArrayBuilder->ConcatStringBuilderLargeStringArrayBuilder->ConcatLargeStringBuilderStringViewArrayBuilder->ConcatStringViewBuilderThese builders are used only by
concatandconcat_ws, and their APIs are specific enough to the needs ofconcat-like callers that it seems unlikely that other call-sites will emerge in the future. This also frees the previous names of these builders to be used by a more broadly useful string builder API.Also make these types
pub(crate), instead ofpub; there is no good reason to make them part of the public API. This is a breaking API change.What changes are included in this PR?
pub(crate), notpubAre these changes tested?
Yes.
Are there any user-facing changes?
Yes, breaking API change -- although these types should probably not have been part of the public API to begin with, and we already made a breaking API change to them as part of other work in v54 (#21538)