fix: HashJoin panic with dictionary-encoded columns in multi-key joins#20441
Open
Tim-53 wants to merge 3 commits intoapache:mainfrom
Open
fix: HashJoin panic with dictionary-encoded columns in multi-key joins#20441Tim-53 wants to merge 3 commits intoapache:mainfrom
Tim-53 wants to merge 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
core
Tim-53
force-pushed
the
fix-20437-hash-join-dictionary-panic
branch
from
b1328a2 to
ffc5b55
Compare
jonathanc-n
reviewed
Feb 20, 2026
Contributor
jonathanc-n
left a comment
jonathanc-n
left a comment
There was a problem hiding this comment.
This looks good, just some small comments
datafusion/core/tests/sql/joins.rs
Outdated
| } | ||
|
|
||
| // Issue #20437: https://github.com/apache/datafusion/issues/20437 | ||
| #[tokio::test] |
Contributor
There was a problem hiding this comment.
We want to keep unit tests at a minimum when possible. Use sqllogictests instead here
github-actions
bot
added
sqllogictest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
flatten_dictionary_arrayreturned only the unique values rather then the full expanded array when being called on aDictionaryArray. When building aStructArraythis caused a length mismatch panic.What changes are included in this PR?
Replaced
array.values()witharrow::compute::cast(array, value_type)inflatten_dictionary_array, which properly expands the dictionary into a full length array matching the row count.Are these changes tested?
Yes, both a new unit test aswell as a regression test were added.
Are there any user-facing changes?
Nope