Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fuzz/fuzz_seeds/postgres_alter_extension.sql
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ ALTER EXTENSION citext ADD MATERIALIZED VIEW public.mv;
ALTER EXTENSION citext DROP FOREIGN TABLE public.ft;
ALTER EXTENSION citext ADD SEQUENCE public.seq;
ALTER EXTENSION citext DROP SCHEMA other;
ALTER EXTENSION citext DROP PROCEDURAL LANGUAGE plpgsql;
14 changes: 14 additions & 0 deletions src/ast/ddl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4928,6 +4928,13 @@ pub enum AlterExtensionOperation {
pub enum AlterExtensionMember {
/// `FOREIGN TABLE object_name`
ForeignTable(ObjectName),
/// `[ PROCEDURAL ] LANGUAGE object_name`
Language {
/// Whether the `PROCEDURAL` keyword was present.
procedural: bool,
/// Language name.
name: Ident,
},
/// `MATERIALIZED VIEW object_name`
MaterializedView(ObjectName),
/// `SCHEMA object_name`
Expand Down Expand Up @@ -4963,6 +4970,13 @@ impl fmt::Display for AlterExtensionMember {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
match self {
AlterExtensionMember::ForeignTable(name) => write!(f, "FOREIGN TABLE {name}"),
AlterExtensionMember::Language { procedural, name } => {
if *procedural {
write!(f, "PROCEDURAL LANGUAGE {name}")
} else {
write!(f, "LANGUAGE {name}")
}
}
AlterExtensionMember::MaterializedView(name) => write!(f, "MATERIALIZED VIEW {name}"),
AlterExtensionMember::Schema(name) => write!(f, "SCHEMA {name}"),
AlterExtensionMember::Sequence(name) => write!(f, "SEQUENCE {name}"),
Expand Down
1 change: 1 addition & 0 deletions src/keywords.rs
Original file line number Diff line number Diff line change
Expand Up @@ -847,6 +847,7 @@ define_keywords!(
PRIOR,
PRIVILEGES,
PROC,
PROCEDURAL,
PROCEDURE,
PROCEDURES,
PROCESSLIST,
Expand Down
10 changes: 10 additions & 0 deletions src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12543,6 +12543,16 @@ impl<'a> Parser<'a> {
Ok(AlterExtensionMember::ForeignTable(
self.parse_object_name(false)?,
))
} else if self.parse_keywords(&[Keyword::PROCEDURAL, Keyword::LANGUAGE]) {
Ok(AlterExtensionMember::Language {
procedural: true,
name: self.parse_identifier()?,
})
} else if self.parse_keyword(Keyword::LANGUAGE) {
Ok(AlterExtensionMember::Language {
procedural: false,
name: self.parse_identifier()?,
})
} else if self.parse_keywords(&[Keyword::MATERIALIZED, Keyword::VIEW]) {
Ok(AlterExtensionMember::MaterializedView(
self.parse_object_name(false)?,
Expand Down
17 changes: 17 additions & 0 deletions tests/sqlparser_postgres.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13530,6 +13530,8 @@ fn alter_extension_member_round_trip_forms(action: &str) {
let sqls = [
format!("ALTER EXTENSION ext_name {action} FOREIGN TABLE ft"),
format!("ALTER EXTENSION ext_name {action} FOREIGN TABLE schema.ft"),
format!("ALTER EXTENSION ext_name {action} LANGUAGE plpgsql"),
format!("ALTER EXTENSION ext_name {action} PROCEDURAL LANGUAGE plpgsql"),
format!("ALTER EXTENSION ext_name {action} MATERIALIZED VIEW mv"),
format!("ALTER EXTENSION ext_name {action} SCHEMA schema_name"),
format!("ALTER EXTENSION ext_name {action} SEQUENCE seq"),
Expand Down Expand Up @@ -13663,6 +13665,19 @@ fn parse_alter_extension_set_schema() {
fn parse_alter_extension_add_member() {
alter_extension_member_round_trip_forms("ADD");

match pg_and_generic().verified_stmt("ALTER EXTENSION ext_name ADD PROCEDURAL LANGUAGE plpgsql")
{
Statement::AlterExtension(AlterExtension {
operation:
AlterExtensionOperation::Add(AlterExtensionMember::Language { procedural, name }),
..
}) => {
assert!(procedural);
assert_eq!(name, Ident::new("plpgsql"));
}
other => panic!("unexpected statement: {other:?}"),
}

for (sql, error) in [
(
"ALTER EXTENSION ext_name ADD",
Expand All @@ -13686,7 +13701,9 @@ fn parse_alter_extension_add_member() {

for member in [
"FOREIGN TABLE",
"LANGUAGE",
"MATERIALIZED VIEW",
"PROCEDURAL LANGUAGE",
"SCHEMA",
"SEQUENCE",
"TABLE",
Expand Down
Loading