Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fuzz/fuzz_seeds/postgres_alter_extension.sql
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ ALTER EXTENSION citext SET SCHEMA other;
ALTER EXTENSION citext UPDATE;
ALTER EXTENSION "uuid-ossp" UPDATE TO '1.1';
ALTER EXTENSION citext ADD TABLE public.t;
ALTER EXTENSION citext DROP VIEW public.v;
3 changes: 3 additions & 0 deletions src/ast/ddl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4928,6 +4928,8 @@ pub enum AlterExtensionOperation {
pub enum AlterExtensionMember {
/// `TABLE object_name`
Table(ObjectName),
/// `VIEW object_name`
View(ObjectName),
}

impl fmt::Display for AlterExtensionOperation {
Expand All @@ -4953,6 +4955,7 @@ impl fmt::Display for AlterExtensionMember {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
match self {
AlterExtensionMember::Table(name) => write!(f, "TABLE {name}"),
AlterExtensionMember::View(name) => write!(f, "VIEW {name}"),
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions src/parser/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12541,6 +12541,8 @@ impl<'a> Parser<'a> {
fn parse_alter_extension_member(&mut self) -> Result<AlterExtensionMember, ParserError> {
if self.parse_keyword(Keyword::TABLE) {
Ok(AlterExtensionMember::Table(self.parse_object_name(false)?))
} else if self.parse_keyword(Keyword::VIEW) {
Ok(AlterExtensionMember::View(self.parse_object_name(false)?))
} else {
self.expected_ref(
"member object type after ADD or DROP",
Expand Down
15 changes: 9 additions & 6 deletions tests/sqlparser_postgres.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13530,6 +13530,7 @@ fn alter_extension_member_round_trip_forms(action: &str) {
let sqls = [
format!("ALTER EXTENSION ext_name {action} TABLE t"),
format!("ALTER EXTENSION ext_name {action} TABLE schema.t"),
format!("ALTER EXTENSION ext_name {action} VIEW v"),
];
for sql in sqls {
pg_and_generic().verified_stmt(&sql);
Expand Down Expand Up @@ -13674,12 +13675,14 @@ fn parse_alter_extension_add_member() {
);
}

assert_eq!(
pg_and_generic()
.parse_sql_statements("ALTER EXTENSION ext_name ADD TABLE")
.unwrap_err(),
ParserError::ParserError("Expected: identifier, found: EOF".to_string())
);
for member in ["TABLE", "VIEW"] {
let sql = format!("ALTER EXTENSION ext_name ADD {member}");
assert_eq!(
pg_and_generic().parse_sql_statements(&sql).unwrap_err(),
ParserError::ParserError("Expected: identifier, found: EOF".to_string()),
"{sql}"
);
}
}

#[test]
Expand Down
Loading