issue: 2607- added support for MapFromEntries#3991
Draft
athlcode wants to merge 6 commits intoapache:mainfrom
Draft
issue: 2607- added support for MapFromEntries#3991athlcode wants to merge 6 commits intoapache:mainfrom
athlcode wants to merge 6 commits intoapache:mainfrom
Conversation
Contributor
|
@athlcode , you might want to wait till the PR on DF's side is merged and released before adding support on comet : |
Contributor
|
Please take a look at : https://datafusion.apache.org/comet/contributor-guide/index.html for help with code formatting, github issue naming conventions and other useful resources. |
…o support/MapFromEntries
…darshan7/datafusion-comet into support/MapFromEntries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2706.
Rationale for this change
Comet already delegated MapFromEntries to the upstream datafusion-spark UDF, but the docs still listed it as unsupported and the native path silently collapsed duplicate keys — diverging from Spark's default spark.sql.mapKeyDedupPolicy=EXCEPTION. Paired with the companion datafusion PR (which makes the native UDF raise [DUPLICATED_MAP_KEY] on duplicates).
What changes are included in this PR?
How are these changes tested?
One new test in CometMapExpressionSuite.scala:
map_from_entries - duplicate keys throw under default EXCEPTION policy — asserts the native path surfaces DUPLICATED_MAP_KEY, confirming error-class parity with Spark.