Open
Conversation
Author
|
Hi, so I understand the issue with the formatting of rust files & so I ran cargo fmt to address the lint failure. But I don't know what's causing the remaining error of "[Spark SQL Tests / spark-sql-auto-sql_core-2/spark-4.0.1"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3970 .
Rationale for this change
This PR adds native support for the
MODEaggregate function in Comet, enabling fully native execution without fallback to Spark.MODEreturns the most frequent value in a group. Unlike simple aggregates, it requires maintaining full frequency state, which is implemented here in a mergeable and execution-friendly form.What changes are included in this PR?
Added a native Rust implementation (
mode.rs) using:Implemented both:
Accumulator(non-grouped execution)GroupsAccumulator(vectorized grouped execution)GroupsAccumulatormaintains per-group frequency maps, ensuring:Added full planner + serde wiring:
Mode)CometMode)AggExprStruct::Mode)The implementation preserves full correctness across all execution stages:
Partial + Final aggregation
Null handling
NULLTie handling
max_by_keyon countsType coverage
Floating-point edge cases
How are these changes tested?
Verified across:
Edge cases tested:
Confirmed no fallback in execution plans